Fix example for ESP8266httpUpdate #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 27.76%@@ master #2251 diff @@
==========================================
Files 20 20
Lines 3641 3641
Methods 334 334
Messages 0 0
Branches 675 675
==========================================
Hits 1011 1011
Misses 2452 2452
Partials 178 178
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this pull request is that the module will reboot after "updateSpiffs" is called to download the file. Then update() can never be called to switch to the new sketch.
This results in a permanent boot loop when the updated sketch.bin is available.
Additionally I changed the example to http instead of https for the path because I was unable to successfully get this to work. I am willing to remove that change if someone can show me how to make this work.