Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST http client example #2704

Merged
merged 10 commits into from
Dec 11, 2019

Conversation

jamesmarlowe
Copy link
Contributor

I thought an example using POST might be useful as per #2678

@codecov-io
Copy link

codecov-io commented Nov 22, 2016

Current coverage is 27.80% (diff: 100%)

Merging #2704 into master will not change coverage

@@             master      #2704   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176          

Powered by Codecov. Last update 7b32e6a...0367479

@josevill
Copy link
Contributor

Thanks for this example, i was looking for a working ino file. +1 👍

@earlephilhower earlephilhower added this to the 2.6.0 milestone Oct 8, 2019
@earlephilhower
Copy link
Collaborator

Simple example, but needs to be updated to use the new HTTPClient interface, not the deprecated one. I think it can be in for 2.6.0. If not, just drop it completely.

@d-a-v d-a-v self-assigned this Oct 31, 2019
@devyte
Copy link
Collaborator

devyte commented Nov 5, 2019

This needs to be looked at and tested. Pushing back,

@devyte devyte modified the milestones: 2.6.0, 2.7.0 Nov 5, 2019
@devyte devyte requested a review from d-a-v November 5, 2019 22:00
@d-a-v d-a-v modified the milestones: 2.7.0, 2.6.3 Dec 11, 2019
@earlephilhower earlephilhower merged commit eb6418f into esp8266:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants