Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getUserPasswordHash() and auth using hash #3328

Closed
wants to merge 1 commit into from
Closed

Conversation

@Sn4k3r
Copy link

Sn4k3r commented Jun 3, 2017

Add getUserPasswordHash() which returns base64 hash.
Now you can use Username&Password or stored base64 hash for
authentication

Add getUserPasswordHash() which returns base64 hash.
Now you can use Username&Password or stored base64 hash for
authentication
@earlephilhower

This comment has been minimized.

Copy link
Collaborator

earlephilhower commented Oct 1, 2019

Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict.

Could you merge it manually with the latest core, so we can consider it for future releases?

@earlephilhower

This comment has been minimized.

Copy link
Collaborator

earlephilhower commented Nov 17, 2019

After reviewing this, I don't see any use case. Since the hash itself is just the b64 encoding of the raw user/pass, it's no more secure than putting them in plaintext in the app.

Seeing as it's also ancient, abandoned, and has merge-conflicts I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.