Skip to content

Conversation

carlsa
Copy link
Contributor

@carlsa carlsa commented Sep 5, 2017

I have increased the I2C buffer from 32 to 128 bytes to match the buffer length that Espressif uses in their ESP32 Arduino core so that code will be compatible.

https://github.com/espressif/arduino-esp32/blob/master/libraries/Wire/src/Wire.h

@michapr
Copy link

michapr commented Jan 19, 2019

somebody could merge it ?
There are problems as sample with SPS30 (and maybe other devices. Best would be configurable buffer of course ;)
(see Sensirion/embedded-sps#14 )

@d-a-v d-a-v added this to the 2.5.0 milestone Jan 19, 2019
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only cost is 192 bytes of heap when TWI is used. Seems harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants