Skip to content

Add timeout to WiFi connection loop in WiFiMulti #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2018
Merged

Add timeout to WiFi connection loop in WiFiMulti #4146

merged 4 commits into from
Jan 20, 2018

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Jan 12, 2018

Fixes #3993 .

@devyte devyte mentioned this pull request Jan 12, 2018
Closed
@devyte devyte self-assigned this Jan 17, 2018
olafnz
olafnz approved these changes Jan 20, 2018
View reviewed changes
Copy link

@olafnz olafnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me thanks. I have tested that it fails after 5s if the network exists but no DHCP. Big improvement.

@devyte devyte merged commit 38fe6fc into esp8266:master Jan 20, 2018
@devyte devyte deleted the issue3993 branch January 20, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@olafnz olafnz olafnz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@devyte devyte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devyte @olafnz