Skip to content

AddServiceTxt returning bool (issue #1962) #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2018
Merged

AddServiceTxt returning bool (issue #1962) #4507

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b2015c
AddServiceTxt returning bool (issue #1962)
fabianoms Mar 13, 2018
43efb12
Merge branch 'master' into patch-1
devyte Mar 16, 2018
cd81390
Merge branch 'master' into patch-1
devyte Mar 16, 2018
c237667
Merge branch 'master' into patch-1
devyte Mar 16, 2018
c0a31e2
Merge branch 'master' into patch-1
devyte Mar 17, 2018
228b7c1
Merge branch 'master' into patch-1
devyte Mar 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions libraries/ESP8266mDNS/ESP8266mDNS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ class MDNSResponder {
}

bool addServiceTxt(char *name, char *proto, char * key, char * value);
void addServiceTxt(const char *name, const char *proto, const char *key,const char * value){
addServiceTxt((char *)name, (char *)proto, (char *)key, (char *)value);
bool addServiceTxt(const char *name, const char *proto, const char *key,const char * value){
return addServiceTxt((char *)name, (char *)proto, (char *)key, (char *)value);
}
void addServiceTxt(String name, String proto, String key, String value){
addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
bool addServiceTxt(String name, String proto, String key, String value){
return addServiceTxt(name.c_str(), proto.c_str(), key.c_str(), value.c_str());
}

int queryService(char *service, char *proto);
Expand Down