Convert to standard PSTR/PROGMEM macros #5458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug referenced in the code that required a custom macro to enable PSTR/PROGMEM compilation ( esp8266#3369 ) was fixed a while back and all PROGMEM references now live in their own save .sections. This patch simply is the output of `sed -i s/PSTR_LEA/PSTR/g *` and `sed -i s/PROGMEM_LEA/PROGMEM/g *` on the codebase and the removal of those defines.
|
As discussed in gitter, the custom PSTR/PROGMEM macros aren't required anymore. |
devyte
approved these changes
Dec 9, 2018
|
Formalize LEA's mdns rewrite |
|
Thanks @earlephilhower ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug referenced in the code that required a custom macro to enable
PSTR/PROGMEM compilation ( #3369 )
was fixed a while back and all PROGMEM references now live in their own
save .sections.
This patch simply is the output of
sed -i s/PSTR_LEA/PSTR/g *andsed -i s/PROGMEM_LEA/PROGMEM/g *on the codebase and the removalof those defines.