Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTA in AP mode #5894

Merged
merged 2 commits into from Mar 21, 2019

Conversation

@zacharydrew
Copy link
Contributor

commented Mar 19, 2019

OTA is broken in AP mode because ESP8266mDNS is checking whether the station is connected before processing. Change the logic to WiFi.isConnected() OR WiFi.softAPgetStationNum()>0 fixes the issue.

OTA is broken in AP mode because ESP8266mDNS is checking whether the …
…station is connected before processing. Change the logic to WiFi.isConnected() OR WiFi.softAPgetStationNum()>0 fixes the issue.
@d-a-v

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

@devyte
devyte approved these changes Mar 19, 2019

@d-a-v d-a-v self-requested a review Mar 21, 2019

@d-a-v
d-a-v approved these changes Mar 21, 2019

@earlephilhower earlephilhower merged commit 7a2e935 into esp8266:master Mar 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Lan-Hekary

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

This commit is the source of this Issue #5915
I Changed the file back to what it was and It fixed the Issue for me ( Please consider another alternative to fix the Original Issue)
I guess this commit is somehow overloading the ESP, as it does not respond to PINGs or TCP requests ..

@devyte

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

@zacharydrew are you absolutely sure you reverted only this specific change and nothing else across the entirestreet core you're using?
@LaborEtArs do you see anything wrong with this commit? It looks correct to me.

@Lan-Hekary

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

I opened wireshark ..
And I noticed that the ESP is flooding the network with a query of itself!!!
That is crazy !!
It's overloading the network .. And this is the source of this issue #5915 ..
the 50ms delay I put there allow the AP network a oom to breathe and process the rest of the requests ..

The Flooding stops once it connects to a Station ..
But it starts again once I disconnect ..
And if there is no station it just keeps flooding the network with queries ..

@Lan-Hekary

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

The flooding only happens if the wifi mode is AP_STA and there is no connection to a WiFi Station ..
If the Mode changes to AP only .. It works Fine ..
And fixes the Problem of the OTA indeed .. Now I am able to upload to the ESP through Hostname.local ..

@devyte

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

Let's discuss in the issue, please add this info there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.