Skip to content

Drop X509 context after successful server verification to save heap space #6065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2019
Merged

Drop X509 context after successful server verification to save heap space #6065

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae812f2
Drop X509 context after successful server verification to save heap s…
dsislak May 10, 2019
46efe2c
Bugfix: Report not connected if there is no ready data and TLS connec…
dsislak May 10, 2019
5c74cff
Merge branch 'master' into master
sislakd May 10, 2019
9c8d712
Merge branch 'master' into master
earlephilhower May 14, 2019
3b360e5
Merge branch 'master' into master
earlephilhower May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ bool WiFiClientSecure::_clientConnected() {
}

uint8_t WiFiClientSecure::connected() {
if (available() || (_clientConnected() && _handshake_done)) {
if (available() || (_clientConnected() && _handshake_done && (br_ssl_engine_current_state(_eng) != BR_SSL_CLOSED))) {
return true;
}
return false;
Expand Down Expand Up @@ -1003,6 +1003,12 @@ bool WiFiClientSecure::_connectSSL(const char* hostName) {
DEBUG_BSSL("Connected!\n");
}
#endif

// Session is already validated here, there is no need to keep following
_x509_minimal = nullptr;
_x509_insecure = nullptr;
_x509_knownkey = nullptr;

return ret;
}

Expand Down