Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fixed bug to select signed bin #6334

Merged

Conversation

thangktran
Copy link
Contributor

From platform.txt, the binary to be uploaded is hardcoded to *.bin file.
This is not the expected behaviour when Signed Update is used.

Fixes: #6323

@thangktran thangktran force-pushed the thangktran/bugfix/auto_select_signed_bin branch from 3a51f2c to 015c4b0 Compare July 23, 2019 19:31
From platform.txt, the binary to be uploaded is hardcoded to *.bin file.
This is not the expected behaviour when Signed Update is used.
@thangktran thangktran force-pushed the thangktran/bugfix/auto_select_signed_bin branch from 015c4b0 to 1311bf4 Compare July 23, 2019 19:32
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@devyte devyte merged commit 705dd39 into esp8266:master Jul 23, 2019
@thangktran thangktran deleted the thangktran/bugfix/auto_select_signed_bin branch July 24, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espota.py passes wrong .bin file
3 participants