Skip to content

Add missing time.h include, use relative include path on time.h includes #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Add missing time.h include, use relative include path on time.h includes #6730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cb31c6
Add missing time.h include
Niek Nov 8, 2019
9b2e528
Change other includes of time.h as well
Niek Nov 8, 2019
9ef7f92
Added comment
Niek Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cores/esp8266/FS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

#include <memory>
#include <Arduino.h>
#include <../include/time.h> // See issue #6714

class SDClass;

Expand Down
2 changes: 1 addition & 1 deletion cores/esp8266/HardwareSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#define HardwareSerial_h

#include <inttypes.h>
#include <time.h>
#include <../include/time.h> // See issue #6714
#include "Stream.h"
#include "uart.h"

Expand Down
2 changes: 1 addition & 1 deletion cores/esp8266/libc_replacements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <limits.h>
#include <errno.h>
#include <string.h>
#include <time.h>
#include <../include/time.h> // See issue #6714
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
Expand Down
2 changes: 1 addition & 1 deletion cores/esp8266/time.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/

#include <stdlib.h>
#include <time.h>
#include <../include/time.h> // See issue #6714
#include <sys/time.h>
#include <sys/reent.h>
#include "sntp.h"
Expand Down