Skip to content

Updated EspSoftwareSerial brings backward compatibility #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Updated EspSoftwareSerial brings backward compatibility #6746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/ESP8266WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ void setup() {
Serial.swap();
// Hardware serial is now on RX:GPIO13 TX:GPIO15
// use SoftwareSerial on regular RX(3)/TX(1) for logging
logger = new SoftwareSerial();
logger->begin(BAUD_LOGGER, 3, 1);
logger = new SoftwareSerial(3, 1);
logger->begin(BAUD_LOGGER);
logger->enableIntTx(false);
logger->println("\n\nUsing SoftwareSerial for logging");
#else
Expand Down
2 changes: 1 addition & 1 deletion libraries/SoftwareSerial
Open in desktop
Submodule SoftwareSerial updated 9 files
+4 −4 examples/loopback/loopback.ino
+2 −2 examples/onewiretest/onewiretest.ino
+3 −3 examples/repeater/repeater.ino
+1 −1 examples/servoTester/servoTester.ino
+1 −1 examples/swsertest/swsertest.ino
+1 −1 library.json
+1 −1 library.properties
+17 −8 src/SoftwareSerial.cpp
+19 −8 src/SoftwareSerial.h
4 changes: 2 additions & 2 deletions libraries/esp8266/examples/SerialStress/SerialStress.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ void setup() {

// using HardwareSerial0 pins,
// so we can still log to the regular usbserial chips
SoftwareSerial* ss = new SoftwareSerial;
ss->begin(SSBAUD, 3, 1);
SoftwareSerial* ss = new SoftwareSerial(3, 1);
ss->begin(SSBAUD);
ss->enableIntTx(false);
logger = ss;
logger->println();
Expand Down