Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use -std=gnu17 instead of -std=c17 #7588

Merged
merged 3 commits into from Nov 15, 2020
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Sep 9, 2020

amend #7552, same build options everywhere

compiler.c.flags=-c {compiler.warning_flags} -std=c17 {build.stacksmash_flags} -Os -g -Wpointer-arith -Wno-implicit-function-declaration -Wl,-EL -fno-inline-functions -nostdlib -mlongcalls -mtext-section-literals -falign-functions=4 -MMD -ffunction-sections -fdata-sections {build.exception_flags} {build.sslflags}

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcspr this is a good catch, but I think you found a problem in platform.txt and not the host tests.

Since we're using gnu++17 for C++, it seems only right to use gnu17 for C, not c17 in the real app build.

Would you like to swap the change around (i.e. modify platform.txt to match existing host makefile)?

@mcspr
Copy link
Collaborator Author

mcspr commented Sep 27, 2020

My assumption was possible portability of the code b/c I do remember some of the __asm__ vs asm comments here:
#6294 (comment)
🤷

Will revise / re-test

@earlephilhower
Copy link
Collaborator

@mcspr ping on this. Could you swap the platform.txt of Makefile to gnu17 instead of the other way around?

@mcspr mcspr changed the title test: use -std=c17 instead of -std=gnu17 test: use -std=gnu17 instead of -std=c17 Nov 15, 2020
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@earlephilhower earlephilhower merged commit 979bbfe into esp8266:master Nov 15, 2020
@mcspr mcspr deleted the patch-1 branch November 15, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants