Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Add Wrong Password wifi status case #7652

Merged
merged 10 commits into from
Oct 15, 2020
Merged

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Oct 14, 2020

Fixes #4152

@devyte devyte changed the title Add Wrong Password wifi status case BREAKING: Add Wrong Password wifi status case Oct 14, 2020
@devyte devyte changed the title BREAKING: Add Wrong Password wifi status case [WIP] BREAKING: Add Wrong Password wifi status case Oct 14, 2020
@devyte devyte added this to the 3.0.0 milestone Oct 14, 2020
@devyte devyte self-assigned this Oct 14, 2020
@devyte devyte changed the title [WIP] BREAKING: Add Wrong Password wifi status case BREAKING: Add Wrong Password wifi status case Oct 14, 2020
@devyte
Copy link
Collaborator Author

devyte commented Oct 14, 2020

This PR is considered breaking, because with the prior code a sketch could just be testing for FAILED, while now a test for either FAILED or WRONG_PASSWORD should be done.

@devyte devyte added the hacktoberfest-accepted Hacktoberfest label Oct 14, 2020
@earlephilhower earlephilhower merged commit 1c624dd into master Oct 15, 2020
@earlephilhower earlephilhower deleted the devyte-wrongpwd branch October 15, 2020 16:52
davisonja added a commit to davisonja/Arduino that referenced this pull request Oct 16, 2020
* master: (37 commits)
  BREAKING: Change return EEPROM.end() to bool (esp8266#7630)
  BREAKING: Change return type of channel() (esp8266#7656)
  BREAKING: Change return type of RSSI() (esp8266#7657)
  Add Copyright notice to Schedule.h (esp8266#7653)
  MDNS MultiInterface (esp8266#7636)
  BREAKING: Add Wrong Password wifi status case (esp8266#7652)
  New flash writing method with offset/memory/size alignment handling (esp8266#7514)
  Fix error when debug enabled but no port chosen (esp8266#7648)
  LEAmDNSv2: change a macro name to be independant from LEAmDNS1 (esp8266#7640)
  Allow test framework to use cores/esp8266/Arduino.h directly (esp8266#7377)
  Update OTA HTTP Server Header Information (esp8266#7633)
  Add missing sntp_init/sntp_stop (esp8266#7628)
  Use direct member initialization instead of ctr initialisation (esp8266#7558)
  Prevent rewriting Updater_Signing.h if content unchanged (esp8266#7627)
  Add WiFi Multi to readme.rst
  Remove stray axtls refs, deprecated compat funcs (esp8266#7626)
  Pull deprecated axtls link (esp8266#7624)
  Redesign ESP8266WiFiMulti.[cpp|h]
  Update README.md (esp8266#7623)
  Eliminate code duplication by template for printNumber(...)/printFloat(...).
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View specific wrong password error upon connecting to network
3 participants