Skip to content

Added GZipped OTA support in elf2bin and PlatformIO #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2020
Merged

Added GZipped OTA support in elf2bin and PlatformIO #7727

merged 1 commit into from
Nov 29, 2020

Conversation

drzony
Copy link
Contributor

@drzony drzony commented Nov 28, 2020

No description provided.

@d-a-v
Copy link
Collaborator

d-a-v commented Nov 28, 2020

Thanks @drzony ! That looks fine.
Basically from what I understand, the regular firmware file is replaced by the compressed one, and the original one renamed to .orig.
Is that because PIO can't handle another name than sketch.bin ?

@drzony
Copy link
Contributor Author

drzony commented Nov 28, 2020 •
edited
Loading

No, that's because elf2bin.py takes --out parameter, so the gzipped file needs to be named according to this parameter. The .orig file is just a backup for reference. This is the generic part, which can be used in Arduino.

The PlatformIO part is only for handling options in .ini file and changing the parameters of esp2bin.py.

earlephilhower
earlephilhower approved these changes Nov 28, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only PIO and custom scripts will use this action, so I don't see any core impact.

d-a-v
d-a-v approved these changes Nov 29, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@earlephilhower earlephilhower merged commit 04b0c27 into esp8266:master Nov 29, 2020
@drzony drzony deleted the gzip-support branch November 29, 2020 18:42
@mcspr mcspr mentioned this pull request Aug 29, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drzony @d-a-v @earlephilhower