Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIFI_RESUME improve speed and example #7877

Merged
merged 6 commits into from Feb 15, 2021
Merged

WIFI_RESUME improve speed and example #7877

merged 6 commits into from Feb 15, 2021

Conversation

mpoettgen
Copy link
Contributor

fixes #7876

  • Improve speed of WiFi.mode(WIFI_RESUME) by passing the last known BSSID to WiFi.begin.
  • Move the WiFiShutdown example to the ESP8266WiFi library example folder.
  • Replace the WiFiShutdown example by a simpler one, showing the minimum use case.

d-a-v
d-a-v approved these changes Feb 14, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@mpoettgen mpoettgen requested a review from d-a-v February 14, 2021 20:33
@mpoettgen
Copy link
Contributor Author

Added some documentation. Thinking about maybe giving this a more prominent introduction somewhere, so that it is easier to find. @d-a-v let me know what you think.

d-a-v
d-a-v approved these changes Feb 14, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation on pseudo-modes looks fine, thanks !

earlephilhower
earlephilhower approved these changes Feb 15, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, especially for documenting things!

@earlephilhower earlephilhower merged commit bc3daef into esp8266:master Feb 15, 2021
@mpoettgen mpoettgen deleted the feature/wifi_resume_improve_speed_and_example branch February 15, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection Speed Problem with WIFI_RESUME
3 participants
@mpoettgen @earlephilhower @d-a-v