Skip to content

minor typo fixes #9106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2024
Merged

minor typo fixes #9106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caac829
minor typo fixes
DRSDavidSoft Mar 18, 2024
f3b5a02
Merge branch 'master' into patch-1
d-a-v Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cores/esp8266/WString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include <utility>
#include <type_traits>

// an abstract class used as a means to proide a unique pointer type
// an abstract class used as a means to provide a unique pointer type
// but really has no body
class __FlashStringHelper;
#define FPSTR(pstr_pointer) (reinterpret_cast<const __FlashStringHelper *>(pstr_pointer))
Expand Down Expand Up @@ -204,7 +204,7 @@ class String {
bool concat(double num);

// if there's not enough memory for the concatenated value, the string
// will be left unchanged (but this isn't signalled in any way)
// will be left unchanged (but this isn't signaled in any way)
template <typename T>
String &operator +=(const T &rhs) {
concat(rhs);
Expand Down Expand Up @@ -343,7 +343,7 @@ class String {
char *wbuffer() { return const_cast<char *>(buffer()); } // Writable version of buffer

// concatenation is done via non-member functions
// make sure we still have access to internal methods, since we optimize based on capacity of both sides and want to manipulate internal buffers directly
// make sure we still have access to internal methods, since we optimize based on the capacity of both sides and want to manipulate internal buffers directly
friend String operator +(const String &lhs, String &&rhs);
friend String operator +(String &&lhs, String &&rhs);
friend String operator +(char lhs, String &&rhs);
Expand Down