Fix bug of not being able to send a single Byte with i2c_master_write #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @berkutta Is there any problem with example, or is your demand not satisfied? |
|
Hi @xiongyumail Both. You can check with a logic analyzer. But the patch in this Pull Request fixes the Bug. |
|
Using |
berkutta
force-pushed
the
bugfix/sending_single_byte
branch
from
46e530b to
61997f1
Compare
|
Ok, thanks, good point. I have changed it now to NULL. |
|
It will be updated later. |
wujiangang
pushed a commit
that referenced
this pull request
Oct 18, 2018
Signed-off-by: XiongYu <xiongyu@espressif.com> Merges #343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the i2c_master_write function without this patch with data length of 1 like used in the Espressif example code it sends 0x00. https://github.com/espressif/ESP8266_RTOS_SDK/blob/master/examples/peripherals/i2c/main/user_main.c#L202