-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Closed as not planned
Closed as not planned
Copy link
Labels
Type: Feature requestFeature request for Arduino ESP32Feature request for Arduino ESP32
Description
Related area
HTTPUpdate
Hardware specification
ESP32
Is your feature request related to a problem?
I'm missing the function to be able to pass an HTTPClient alongside the NetworkClient:
Currently standard practice is to call this function:
t_httpUpdate_return update(NetworkClient &client, const String &url, const String ¤tVersion = "", HTTPUpdateRequestCB requestCB = NULL);
It would be nice to have this alternative:
t_httpUpdate_return update(NetworkClient &client, HTTPClient& httpClient, const String& url, const String& currentVersion = "", HTTPUpdateRequestCB requestCB = NULL);
This way if for any reason it is neccessary to add headers to the httpClient it can be done adequately.
Describe the solution you'd like
This should be an easy fix, just adding the prototype to the header file and have the function use the passed HTTPClient reference instead of making a new one.
Describe alternatives you've considered
No response
Additional context
No response
I have checked existing list of Feature requests and the Contribution Guide
- I confirm I have checked existing list of Feature requests and Contribution Guide.
Metadata
Metadata
Assignees
Labels
Type: Feature requestFeature request for Arduino ESP32Feature request for Arduino ESP32