Skip to content

HTTPUpdate Feature to be able to pass an HTTPClient alongside the WiFiClient #10090

@Style12341

Description

@Style12341

Related area

HTTPUpdate

Hardware specification

ESP32

Is your feature request related to a problem?

I'm missing the function to be able to pass an HTTPClient alongside the NetworkClient:
Currently standard practice is to call this function:

 t_httpUpdate_return update(NetworkClient &client, const String &url, const String &currentVersion = "", HTTPUpdateRequestCB requestCB = NULL);

It would be nice to have this alternative:

t_httpUpdate_return update(NetworkClient &client, HTTPClient& httpClient, const String& url, const String& currentVersion = "", HTTPUpdateRequestCB requestCB = NULL);

This way if for any reason it is neccessary to add headers to the httpClient it can be done adequately.

Describe the solution you'd like

This should be an easy fix, just adding the prototype to the header file and have the function use the passed HTTPClient reference instead of making a new one.

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions