global WiFiClass is required by wifi system but is not defined with NO_GLOBAL_INSTANCES

[apalazzi]

Board

Fysetc E4

Device Description

3D printer board

Hardware Configuration

nothing relevant for the issue

Version

latest stable Release (if not listed below)

Type

Task

IDE Name

esp.py

Operating System

Linux

Flash frequency

40

PSRAM enabled

yes

Upload speed

115200

Description

When setting #define NO_GLOBAL_INSTANCES the WiFiClass Wifi is not declared in libraries/WiFi/src/WiFi.h, however other classes such APClass in libraries/WiFi/src/AP.cpp depends on it to work properly. For some reason the code still compiles but when trying to connect in STA mode the connection doesn't work.

A preferable outcome would be to make the build fail entirely, or document somewhere the NO_GLOBAL_INSTANCES and its pitfalls.

Sketch

-

Debug Message

-

Other Steps to Reproduce

1. #define NO_GLOBAL_INSTANCES in your code
2. try to use the wifi stack

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[me-no-dev]

Could you please explain the reasons for defining NO_GLOBAL_INSTANCES? What was the expected outcome for using it?

[apalazzi]

Reasons: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ri-global

The expected outcome is to not have global variables defined; if a subsystem relies on globals document it and fail loudly when someone try to use it.