Skip to content

fix(async): Update IP setup in AsyncUDP #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Conversation

me-no-dev
Copy link
Member

This pull request refactors the AsyncUDP class in AsyncUDP.cpp to simplify and standardize the handling of IP address types. The changes primarily replace conditional logic with more concise and consistent macros, improving readability and maintainability.

Refactoring for IP Address Handling:

  • AsyncUDP::listen: Replaced IP_SET_TYPE_VAL with IP_SET_TYPE and used IP_GET_TYPE to standardize the setting of IP address types for both local_ip and remote_ip.
  • AsyncUDP::listenMulticast: Simplified the handling of IPv4 and IPv6 addresses by replacing conditional logic with IP_SET_TYPE and ip_addr_set_any, reducing complexity and improving clarity.

Fixes: #11553

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 60e70dc

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 60e70dc.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/AsyncUDP/examples/AsyncUDPClient------------
libraries/AsyncUDP/examples/AsyncUDPMulticastServer------------
libraries/AsyncUDP/examples/AsyncUDPServer------------

@me-no-dev me-no-dev requested a review from P-R-O-C-H-Y July 8, 2025 11:23
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 8, 2025
@me-no-dev me-no-dev merged commit 241e257 into master Jul 8, 2025
73 of 79 checks passed
@me-no-dev me-no-dev deleted the bugfix/asyncudp_v6 branch July 8, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class "ip4_addr" has no member "u_addr" error in AsyncUDP if IPv6 is disabled
3 participants