feat(zigbee): Add multistate endpoint support #11609
Conversation
P-R-O-C-H-Y
requested review from
lucasssvaz,
SuGlider and
me-no-dev
as code owners
P-R-O-C-H-Y
added
Status: Blocked upstream 🛑
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 15m 5s ⏱️ Results for commit 5bd2ed1. ♻️ This comment has been updated with latest results. |
P-R-O-C-H-Y
removed
the
Status: Blocked upstream 🛑
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Currently, this example supports the following targets. | ||
|
|
||
| | Supported Targets | ESP32-C6 | ESP32-H2 | | ||
| | ----------------- | -------- | -------- | |
There was a problem hiding this comment.
you should update all those to also include C5 or maybe find a better way to define what chips are supported
There was a problem hiding this comment.
Will update all examples before we release 3.3.1. Good point
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Zigbee multistate input/output endpoints by implementing a new ZigbeeMultistate class. The implementation includes predefined application types following Zigbee specification standards and provides functionality for both input sensors and output actuators with discrete state values.
Key changes:
- Implementation of complete
ZigbeeMultistateclass with input/output cluster support - Addition of comprehensive example demonstrating both standard and custom multistate devices
- Integration of new class into the Zigbee library build system and documentation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| libraries/Zigbee/src/ep/ZigbeeMultistate.h | Header file defining the ZigbeeMultistate class with predefined application types and public API |
| libraries/Zigbee/src/ep/ZigbeeMultistate.cpp | Implementation of multistate input/output functionality with cluster management and state control |
| libraries/Zigbee/src/Zigbee.h | Adds include for the new ZigbeeMultistate header file |
| libraries/Zigbee/keywords.txt | Adds Arduino IDE syntax highlighting for all ZigbeeMultistate methods and constants |
| libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/ci.json | CI configuration for the multistate example |
| libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/Zigbee_Multistate_Input_Output.ino | Complete example demonstrating standard and custom multistate device usage |
| libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/README.md | Documentation for the multistate example with setup and usage instructions |
| docs/en/zigbee/ep_multistate.rst | Comprehensive API documentation for the ZigbeeMultistate class |
| CMakeLists.txt | Adds ZigbeeMultistate.cpp to the build system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/README.md
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/README.md
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/Zigbee_Multistate_Input_Output.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/Zigbee_Multistate_Input_Output.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output/Zigbee_Multistate_Input_Output.ino
Outdated
Show resolved
Hide resolved
Description of Change
This pull request adds support for Multistate input/output endpoint. Key changes include the implementation of a new
ZigbeeMultistateclass, updates to the example project to demonstrate its usage, and modifications to related configuration and documentation files.Tests scenarios
Tested using C6 with provided Multistage Input/Output example using HA (Multistate clusters are not yet supported there, so it was just manual reading of the attributes).
Related links