Skip to content

Conversation

JakubAndrysek
Copy link
Collaborator

Description of Change

This pull request refactors the HTTP header collection logic in the HTTPClient library to use a std::vector for managing response headers, adds support for collecting all headers, and updates the example and CI configuration accordingly. The changes simplify memory management, improve flexibility, and make it easier to work with dynamic sets of headers.

Test Scenarios

Code was tested on ESP32 and ESP32S3

Related links

Closes issue #10802 … example, close #10802

@JakubAndrysek JakubAndrysek requested review from lucasssvaz and a team as code owners August 28, 2025 09:24
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 69549c8

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/HTTPClient/examples/Authorization--------------
libraries/HTTPClient/examples/BasicHttpClient--------------
libraries/HTTPClient/examples/BasicHttpsClient--------------
libraries/HTTPClient/examples/CustomHeaders--------------
libraries/HTTPClient/examples/HTTPClientEnterprise--------------
libraries/HTTPClient/examples/ReuseConnection--------------
libraries/HTTPClient/examples/StreamHttpClient--------------

Copy link
Contributor

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 69549c8.

@lucasssvaz lucasssvaz requested a review from me-no-dev August 28, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPClient code does not collect header names
1 participant