fix(BLE): Fix double callback and secure examples #11812
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 13m 12s ⏱️ Results for commit 118996d. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes BLE double callback issues and improves secure examples with IO capabilities and security reset functionality. It addresses authentication, security state management, and provides better documentation for BLE security implementation.
- Fixes double callback invocations in BLE characteristic operations
- Adds security reset functionality on disconnect events
- Updates secure examples with proper IO capabilities and MITM configuration
- Adds comprehensive BLE security documentation with pairing methods and troubleshooting
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BLEUtils.cpp | Adds missing BLE_GAP_EVENT_AUTHORIZE case for debug text |
| BLEServer.cpp | Adds security reset calls on disconnect for both Bluedroid and NimBLE |
| BLESecurity.h | Adds resetSecurity() method declaration |
| BLESecurity.cpp | Implements security reset functionality and fixes default IO capability |
| BLEClient.cpp | Adds security reset calls on disconnect for both stacks |
| BLECharacteristic.cpp | Removes duplicate callback invocations to fix double callback issue |
| Server_secure_static_passkey.ino | Updates with proper IO capabilities, MITM settings, and NVS clearing |
| Server_secure_authorization/ | New authorization example with proper security configuration |
| Client_secure_static_passkey.ino | Updates with matching security settings and NVS clearing |
| README.md | Comprehensive BLE security documentation with pairing methods and troubleshooting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description of Change
Add fixes for BLE:
Test Scenarios
Tested locally
Related links
Closes #11805