-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(esp32): Compiler warning - parameter byte
in function EspClass::magicFlashChipSize shadows typedef uint8_t byte;
#11827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello martinbudden, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
byte
in function EspClass::magicFlashChipSize shadows typedef uint8_t byte;
byte
in function EspClass::magicFlashChipSize shadows typedef uint8_t byte;
byte
in function EspClass::magicFlashChipSize shadows typedef uint8_t byte;
byte
in function EspClass::magicFlashChipSize shadows typedef uint8_t byte;
Test Results 76 files 76 suites 13m 16s ⏱️ Results for commit a8247b1. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @martinbudden, this will also apply on the other functions in EspClass
:
uint32_t EspClass::magicFlashChipSpeed(uint8_t byte)
and
FlashMode_t EspClass::magicFlashChipMode(uint8_t byte)
Can you change in all methods (including the one in PR) byte
to flashByte
to solve that?
The paramter
byte
in functionuint32_t EspClass::magicFlashChipSize(uint8_t byte)
shadows the globaltypedef uint8_t byte;
This causes the warning:
warning: declaration of 'byte' shadows a global declaration [-Wshadow]
when compiled with option
-Wshadow
.Description of Change
Renamed parameter
byte
tooctet
.Test Scenarios
Code compiles without warning when change made.
Related links
None