-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Refactor touch pad error logging #11878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Removed duplicated log_e("No touch pad on selected pin!") calls from multiple functions. - Centralized the error log inside digitalPinToTouchChannel(). - Extended the error message to include the pin number for better debugging context. - Added log_e() in digitalPinToTouchChannel() when no touch sensor is available on the chip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Kolodieiev for the PR!
@Kolodieiev - Have you signed the CLA? Please sign it in case it has not been done. Thanks! |
Test Results 76 files 76 suites 15m 24s ⏱️ Results for commit dec735b. ♻️ This comment has been updated with latest results. |
👋 Hello Kolodieiev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@SuGlider I had some issues with my GitHub account, but they have been resolved. I have now signed the CLA. Thank you! |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
This pull request adds the display of the pin number when an incorrect pin is specified and removes duplicated log lines across multiple functions.
These changes improve debugging clarity.
Problem Description
Previously, functions like touchRead() would log "No touch pad on selected pin!" when an invalid pin was specified, but the log did not include the actual pin number.
This made it harder to identify which pin caused the issue during debugging.
Description of Change
Test Scenario
This change has been tested on the following hardware and software configuration:
Hardware: ESP32-S3-WROOM-1 N16R8, ESP-WROOM-32
Software: Pioarduino 1.1.0