-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(usb): global event task stack size normalization #11895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 14m 53s ⏱️ Results for commit 8a5fcb4. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
Arduino Event Task is harcoded in some places of the Core code.
There is no unique/simple way to set a global size for the event task stack.
This PR created a simple way to normalize the USB/HWCDC/SERIAL stack size using the same KConfig value
ARDUINO_SERIAL_EVENT_TASK_STACK_SIZE
as default value.By this way, it is possible to change it using Menu Config or a
-DARDUINO_SERIAL_EVENT_TASK_STACK_SIZE=4096
inbuild_opt.h
file (using Arduino IDE).The same is applied to the Task Priority using
ARDUINO_SERIAL_EVENT_TASK_PRIORITY
Test Scenarios
ESP32 CI only
Related links
Fixes #11891