Skip to content

Conversation

lucasssvaz
Copy link
Member

Description of Change

Fixed:

  • Libs filename in generated Json
  • Version substitution without checks
  • Broken component upload

Test Scenarios

Tested locally

@lucasssvaz lucasssvaz self-assigned this Oct 8, 2025
@lucasssvaz lucasssvaz added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a846089

@lucasssvaz lucasssvaz requested a review from me-no-dev October 8, 2025 23:24
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 9, 2025
@me-no-dev me-no-dev merged commit 956bc3e into espressif:master Oct 9, 2025
19 checks passed
@lucasssvaz lucasssvaz deleted the ci/release_fix branch October 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants