Skip to content

Conversation

luismiKode
Copy link
Contributor

Description of Change

This pull request updates the KodeDot board definition to support the latest ESP32-S3R8 revision using OPI flash and OPI PSRAM.
It also corrects the pin mapping for the onboard AMOLED, SD card (1-bit SDMMC), NeoPixel, and IO-expander-based button layout.

Changes include:

  • Updated boards.txt to match 32 MB OPI flash configuration.
  • Updated pins_arduino.h for:
    • AMOLED connections over OPI-style SPI bus.
    • SD card switching from QSPI_HOST to SDMMC (1-bit).
    • NeoPixel and bottom button reassigned to IO expander.
    • Added default SPI defines for library compatibility.
  • Minor cleanup of unused debug menu entries.

Test Scenarios

  • Tested on KodeDot (ESP32-S3R8) board with 32 MB OPI flash and 8 MB OPI PSRAM.
  • Verified LCD rendering, SD card access, button input, and NeoPixel operation.
  • Compiled and uploaded using Arduino IDE 2.3.6.
  • Confirmed successful boot and peripheral initialization.

Related Links

Closes no existing issue, but updates KodeDot board configuration to latest hardware revision.
https://docs.kode.diy/en

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "style(board): remove extra blank lines from DebugLevel section":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello luismiKode, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0174890

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Oct 9, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, otherwise good.
Please also sign the CLA @luismiKode

@luismiKode luismiKode requested a review from P-R-O-C-H-Y October 9, 2025 11:01
@luismiKode
Copy link
Contributor Author

@P-R-O-C-H-Y Regarding the CLA, I already signed it about half an hour ago, maybe it just hasn’t refreshed yet?

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y Regarding the CLA, I already signed it about half an hour ago, maybe it just hasn’t refreshed yet?

It can take some time, don't worry. Thanks for letting me know.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Oct 9, 2025

OK I see the issue here, the commits you are doing are not done by the GH account, its done by LusimiCollado.
You need to use your GH account for the commits.

@P-R-O-C-H-Y
Copy link
Member

In case you can't redo the commits, close the PR and open a new one where you will do the commits by correct account.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Oct 9, 2025
@luismiKode
Copy link
Contributor Author

In case you can't redo the commits, close the PR and open a new one where you will do the commits by correct account.

I’ve redone all commits using my correct GitHub account (luismiKode lmcollado@kode.diy), and force-pushed the branch.
The CLA should now recognize the commits properly.
Thanks for catching that!

@P-R-O-C-H-Y
Copy link
Member

All good now :) ready to be merged.

@luismiKode
Copy link
Contributor Author

All good now :) ready to be merged.

Thanks for the support :)

@me-no-dev me-no-dev merged commit b20655a into espressif:master Oct 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants