Add M5Stack-FIRE board #1647
Add M5Stack-FIRE board #1647
Conversation
| static const uint8_t G5 = 5; | ||
| static const uint8_t G13 = 13; | ||
| static const uint8_t G0 = 0; | ||
| static const uint8_t G34 = 34; |
variants/m5stack_fire/pins_arduino.h
Outdated
| static const uint8_t RX = 3; | ||
|
|
||
| static const uint8_t TXD2 = 17; | ||
| static const uint8_t RXD2 = 16; |
There was a problem hiding this comment.
16 and 17 are connected to PSRAM
There was a problem hiding this comment.
Yes, it should remove.
There was a problem hiding this comment.
I think you forgot those lines :)
boards.txt
Outdated
| m5stack-fire.menu.FlashFreq.80=80MHz | ||
| m5stack-fire.menu.FlashFreq.80.build.flash_freq=80m | ||
| m5stack-fire.menu.FlashFreq.40=40MHz | ||
| m5stack-fire.menu.FlashFreq.40.build.flash_freq=40m |
There was a problem hiding this comment.
find what works on the board and let's remove this option.
boards.txt
Outdated
| m5stack-fire.menu.FlashMode.qout.build.boot=qout | ||
| m5stack-fire.menu.FlashMode.dout=DOUT | ||
| m5stack-fire.menu.FlashMode.dout.build.flash_mode=dout | ||
| m5stack-fire.menu.FlashMode.dout.build.boot=dout |
There was a problem hiding this comment.
find what works on the board and let's remove this option. DIO or QIO
boards.txt
Outdated
| m5stack-fire.menu.PartitionScheme.no_ota.upload.maximum_size=2097152 | ||
| m5stack-fire.menu.PartitionScheme.min_spiffs=Minimal SPIFFS (Large APPS with OTA) | ||
| m5stack-fire.menu.PartitionScheme.min_spiffs.build.partitions=min_spiffs | ||
| m5stack-fire.menu.PartitionScheme.min_spiffs.upload.maximum_size=1966080 |
There was a problem hiding this comment.
those partitions make no sense. let's discuss this and add new options :)
There was a problem hiding this comment.
Yes, there is no partition for 16MB Flash, should add new options.
boards.txt
Outdated
| m5stack-fire.menu.PSRAM.disabled=Disabled | ||
| m5stack-fire.menu.PSRAM.disabled.build.defines= | ||
| m5stack-fire.menu.PSRAM.enabled=Enabled | ||
| m5stack-fire.menu.PSRAM.enabled.build.defines=-DBOARD_HAS_PSRAM -mfix-esp32-psram-cache-issue |
There was a problem hiding this comment.
Put enabled on top so it's the default option and why not enable it by default by adding the defines to the main section?
|
Thank you very much for your comments, I push the new PR. |
|
@0x1abin I would like to merge this. Can you please remove pins 16 and 17 from the variant header? |
* Add M5Stack-FIRE board * updated m5stack-fire boards.txt * remove pins 16 and 17
Add M5Stack-FIRE board 16MB FLASH, 4MB PSRAM.