Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-functional deinit/init in BLEDevice.cpp #3267

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@billprozac
Copy link
Contributor

commented Sep 25, 2019

Pretty sure this was a typo as the deinit doesn't actually allow for reinit if that is an ifndef. Changed in my local copy and can now deinit and reinit just fine. Also, not sure why we are checking for the architecture here. Just curious.

Pretty sure this was a typo as the deinit doesn't actually allow for reinit if that is an ifndef.  Changed in my local copy and can now deinit and reinit just fine.  Also, not sure why we are checking for the architecture here.  Just curious.
@billprozac billprozac changed the title Update BLEDevice.cpp Non-functional deinit/init in BLEDevice.cpp Sep 26, 2019
@me-no-dev

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

yup :) typo!

@me-no-dev me-no-dev merged commit 9bbd720 into espressif:master Sep 26, 2019
20 checks passed
20 checks passed
Build Arduino IDE Tests 0
Details
Build Arduino IDE Tests 1
Details
Build Arduino IDE Tests 2
Details
Build Arduino IDE Tests 3
Details
Build Arduino IDE Tests 4
Details
Build Arduino IDE Tests 5
Details
Build Arduino IDE Tests 6
Details
Build Arduino IDE Tests 7
Details
Build Arduino IDE Tests 8
Details
Build Arduino IDE Tests 9
Details
Build Arduino IDE Tests 10
Details
Build Arduino IDE Tests 11
Details
Build Arduino IDE Tests 12
Details
Build Arduino IDE Tests 13
Details
Build Arduino IDE Tests 14
Details
Build Arduino IDE Tests 15
Details
Build Arduino IDE Tests 16
Details
Build Arduino IDE Tests 17
Details
Build PlatformIO Tests
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@billprozac billprozac deleted the billprozac:patch-1 branch Sep 28, 2019
@billprozac

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2019

thanks, boss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.