Fixes issue-3153 - Allocating enough memory to construct the entire UUID as a String #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
Any time. @me-no-dev I would have solved this 3 days earlier, except I became derailed by either a subtle bug or my misunderstanding of the way that CString#c_str() is working. Would you mind jumping on https://www.esp32.com/viewtopic.php?f=19&t=12529 and explaining what I'm not understanding? |
|
Did this fix get merged into ESP32 Arduino Core library v1.0.4? I'm still seeing this problem. |
|
Appears to be on the 1.0.4 and 1.0.4-rc1 tags
5bff89f
…On Fri, Jan 17, 2020 at 4:37 AM Anders Nelson ***@***.***> wrote:
Did this fix get merged into ESP32 Arduino Core library v1.0.4? I'm still
seeing this problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3297?email_source=notifications&email_token=AAFDXBZJVWKSZX6J3GBEM5LQ6CSN7A5CNFSM4I3SJEKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFCZYI#issuecomment-575286497>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDXBZMRJTKHM6Y5HGX6FTQ6CSN7ANCNFSM4I3SJEKA>
.
|
|
Maybe so, but I had updated to v1.0.4 via the Arduino board manager and the issue persisted. I patched the code myself and it now works well. |
|
So it sounds like a problem with the Arduino board manager.
…On Fri, Jan 17, 2020 at 9:12 AM Anders Nelson ***@***.***> wrote:
Maybe so, but I had updated to v1.0.4 via the Arduino board manager and
the issue persisted. I patched the code myself and it now works well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3297?email_source=notifications&email_token=AAFDXB6NL3CQLUWAZULLWL3Q6DSXBA5CNFSM4I3SJEKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJF4IWA#issuecomment-575390808>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDXB4B5YUDWKXWAJD5SG3Q6DSXBANCNFSM4I3SJEKA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3153