Fixed wrong relative path for lwip/arpa/inet.h #3425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path given in the original lwip header from esp-idf refers to a path that doesn't exist in arduino-esp32.
|
This will need to be submitted to esp-idf and not here since this header is copied as-is from there |
|
@atanisoft But the problem is that the path structure of the header files in the esp-idf is different than the one in arduino-esp32. When I'm including the header file in an Arduino project, I'm getting this error mathiasbredholt/libmapper-arduino#3. |
|
Be that as it may, I don't think this will be allowed to merge without being fixed in https://github.com/espressif/esp-idf. @me-no-dev what are your thoughts? |
|
this is a bug in ESP-IDF. Please post the issue there and state that you are using IDF3.2 of Arduino :) I can not accept any changes to |
mathiasbredholt
added a commit
to mathiasbredholt/esp-idf
that referenced
this pull request
Nov 8, 2019
The relative path breaks compatibility with arduino-esp32 as the path doesn't exist in arduino-esp32. espressif/arduino-esp32#3425
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Dec 16, 2019
The relative path breaks compatibility with arduino-esp32 as the path doesn't exist in arduino-esp32. espressif/arduino-esp32#3425 Closes #4308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path given in the original lwip header from esp-idf refers to a path that doesn't exist in arduino-esp32.