Skip to content

SPI: Fix discarded-qalifiers warning when compiling with all warnings #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2019
Merged

SPI: Fix discarded-qalifiers warning when compiling with all warnings #3458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37872ed
SPI: Fix discarded-qalifiers warning when compiling with all warnings
davefiddes Nov 7, 2019
42b8ca9
SPI:Ensure all local functions are marked static
davefiddes Nov 11, 2019
ad73f57
SPI: Remove unused local __spiTranslate24 function
davefiddes Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions cores/esp32/esp32-hal-spi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,17 +532,7 @@ uint8_t spiTransferByte(spi_t * spi, uint8_t data)
return data;
}

uint32_t __spiTranslate24(uint32_t data)
{
union {
uint32_t l;
uint8_t b[4];
} out;
out.l = data;
return out.b[2] | (out.b[1] << 8) | (out.b[0] << 16);
}

uint32_t __spiTranslate32(uint32_t data)
static uint32_t __spiTranslate32(uint32_t data)
{
union {
uint32_t l;
Expand Down Expand Up @@ -630,7 +620,7 @@ uint32_t spiTransferLong(spi_t * spi, uint32_t data)
return data;
}

void __spiTransferBytes(spi_t * spi, uint8_t * data, uint8_t * out, uint32_t bytes)
static void __spiTransferBytes(spi_t * spi, const uint8_t * data, uint8_t * out, uint32_t bytes)
{
if(!spi) {
return;
Expand Down