Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPClient Port #347

Merged
merged 7 commits into from May 19, 2017

Conversation

Projects
None yet
5 participants
@copercini
Copy link
Collaborator

commented May 3, 2017

Changed SHA1 fingerprint by Root CA verification
Changed log system
Some WiFIClientSecure fixes

copercini added some commits May 3, 2017

Remove workaround of sockets always return -76
Remove workaround of sockets always return -76 (because it's fixed on IDF now)
Remove delay during handshake (improving stability)
Initial port from ESP8266
Changed SHA1 fingerprint by Root CA verification
Changed log system
bool begin(String host, uint16_t port, String uri = "/");
bool begin(String host, uint16_t port, String uri, const char* CAcert);
// deprecated, use the overload above instead
bool begin(String host, uint16_t port, String uri, bool https, const char* CAcert) __attribute__ ((deprecated));

This comment has been minimized.

Copy link
@igrr

igrr May 4, 2017

Member

What's the logic for adding a deprecated function, when adding a library for the first time?

@copercini

This comment has been minimized.

Copy link
Collaborator Author

commented May 4, 2017

I tried to keep it as closer possible to ESP8266 library, it stays so close that even the deprecated functions remain deprecated =P
Removed...

@skateone

This comment has been minimized.

Copy link

commented May 12, 2017

when is tihs going to be available in the master branch?

@me-no-dev me-no-dev merged commit 51a4432 into espressif:master May 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@proppy

This comment has been minimized.

Copy link

commented Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.