Skip to content

Added file.close to examples #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2020
Merged

Added file.close to examples #3611

merged 1 commit into from
Jan 20, 2020

Conversation

lbernstone
Copy link
Contributor

Fixes #3609

@me-no-dev
Copy link
Member

IMO close is called on the exit of the function anyway as part of the destruct. What am I missing?

@lbernstone
Copy link
Contributor Author

In practice, I would agree. But, in an example, I think it is more appropriate to demonstrate good hygiene on the file handles. The user with the issue was somehow able to write the file and it did not close/persist.

@me-no-dev
Copy link
Member

sure

@me-no-dev me-no-dev merged commit cd85239 into espressif:master Jan 20, 2020
@lbernstone lbernstone deleted the examples_fileclose branch November 4, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG? ESP32 FFAT partition not hold second file(with format false!)
2 participants
@lbernstone @me-no-dev