Skip to content

Have BLECLient gattc event handlers verify conn_id #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2020
Merged

Have BLECLient gattc event handlers verify conn_id #4064

merged 2 commits into from
Sep 30, 2020

Conversation

buxtronix
Copy link
Contributor

esp32 BLE core seems to send events to all clients, even those for others. This PR ensures that events are only handled when the connection is correct.

@buxtronix buxtronix mentioned this pull request Jun 6, 2020
Closed
@buxtronix
Copy link
Contributor Author

I note that Espresso's ESP-IDF also acknowledges the event being broadcast to all clients:

https://github.com/espressif/esp-idf/blob/master/examples/bluetooth/bluedroid/ble/gattc_multi_connect/main/gattc_multi_connect.c#L150

@me-no-dev me-no-dev merged commit 1f6b0b3 into espressif:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chegewara chegewara chegewara approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buxtronix @chegewara @me-no-dev