Skip to content

Update MDNSResponder::addService to return a boolean #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Update MDNSResponder::addService to return a boolean #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efb6e0d
Changed MDNSResponder::addService to return a bool
thebigpotatoe Sep 27, 2020
87e810e
Updated MDNSResponder::addService to return a bool
thebigpotatoe Sep 27, 2020
d09cdce
Update ESPmDNS.h
thebigpotatoe Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libraries/ESPmDNS/src/ESPmDNS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void MDNSResponder::disableWorkstation(){
}
}

void MDNSResponder::addService(char *name, char *proto, uint16_t port){
bool MDNSResponder::addService(char *name, char *proto, uint16_t port){
char _name[strlen(name)+2];
char _proto[strlen(proto)+2];
if (name[0] == '_') {
Expand All @@ -146,7 +146,9 @@ void MDNSResponder::addService(char *name, char *proto, uint16_t port){

if(mdns_service_add(NULL, _name, _proto, port, NULL, 0)) {
log_e("Failed adding service %s.%s.\n", name, proto);
return false;
}
return true;
}

bool MDNSResponder::addServiceTxt(char *name, char *proto, char *key, char *value){
Expand Down
10 changes: 5 additions & 5 deletions libraries/ESPmDNS/src/ESPmDNS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ class MDNSResponder {
setInstanceName(String(name));
}

void addService(char *service, char *proto, uint16_t port);
void addService(const char *service, const char *proto, uint16_t port){
addService((char *)service, (char *)proto, port);
bool addService(char *service, char *proto, uint16_t port);
bool addService(const char *service, const char *proto, uint16_t port){
return addService((char *)service, (char *)proto, port);
}
void addService(String service, String proto, uint16_t port){
addService(service.c_str(), proto.c_str(), port);
bool addService(String service, String proto, uint16_t port){
return addService(service.c_str(), proto.c_str(), port);
}

bool addServiceTxt(char *name, char *proto, char * key, char * value);
Expand Down