DOCUMENTATION: Moved installation instructions to separate page #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Raienryu97
commented
Aug 4, 2017
Raienryu97
commented
- Added Fedora to contents table
- Added Issue/Bug Report section to README
- Some minor improvements
* Added Fedora to contents table * Added Issue/Bug Report section to README * Some minor improvements
|
NICE! Just an observation: If rename the folder "doc" to "docs" Github accept it's documentation (like ISSUE_TEMPLATE) inside this, cleaning the root folder |
* Also move ISSUE_TEMPLATE.md to docs directory
* This makes it consistent instead of having few local and few pointing to espressif/arduino-esp32 by all linking to local files
|
Great idea @copercini . I've also linked all links to local files wherever possible so it would be consistent and I felt it makes more sense than pointing to espressif/arduino-esp32 even in forks. |
|
is this ready for merging? |
|
Yep. Done from my side. Edit: (6th Aug) |
|
Maybe the "Contents" summary and "Installation Instructions" can be suppressed in just one thing, because both have almost the same links |
|
How about the current one @copercini , @me-no-dev ? |
|
@Raienryu97 Awesome! |
Raienryu97
added a commit
to Raienryu97/arduino-esp32
that referenced
this pull request
Aug 18, 2017
…essif#561) * DOCUMENTATION: Moved installation instructions to separate page * Added Fedora to contents table * Added Issue/Bug Report section to README * Some minor improvements * DOCUMENTATION: Rename directory doc to docs * Also move ISSUE_TEMPLATE.md to docs directory * DOCUMENTATION: Use current repo's files * This makes it consistent instead of having few local and few pointing to espressif/arduino-esp32 by all linking to local files * DOCUMENTATION: Fix hyperlink to issue/bug template in contents * DOCUMENTATION: contents: supress platform specific installation instruction
VojtechBartoska
added
the
Type: Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.