Skip to content

Fix ledc panic’ed when wrong setup of frequency and bit width #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix ledc panic’ed when wrong setup of frequency and bit width #6371

merged 2 commits into from
Mar 10, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

Summary

Fixing ledc issue when result of IDFs functions was not checked before calling next function causing core panic’ed.
Changed ledcSoftwareFade example to work on all SOCs.

Impact

Fix.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev March 3, 2022 14:18
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Mar 3, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Bug 🐛 All bugs label Mar 3, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.3 milestone Mar 3, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Mar 3, 2022
@me-no-dev me-no-dev merged commit 66596fa into espressif:master Mar 10, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the ledcFix branch April 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs. Type: Bug 🐛 All bugs
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@P-R-O-C-H-Y @me-no-dev