Fix uploader tool for ESPduino32 in boards.txt #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@me-no-dev sorry for picking you randomly for a ping among the 6 espressif members. Is there anything I have to do to have the PR move forward ? |
|
looks good and will be merged before release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The uploader tool for that ESPduino32 board and its clones was erroneous in boards.txt.
This triggered a java nullpointer exception when trying to upload.
Tests scenarios
Tested on an "AZ Delivery D1 R32" board which is a clone of the ESPduino32.
Tested by manually editing boards.txt in Arduino-esp32 core v2.0.3-RC1.