Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonexisting folder from include path #6798

Merged
merged 4 commits into from
May 27, 2022

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented May 25, 2022

Description of Change

The PlatformIO builder scripts attempt to include tools/sdk/esp32/include/config to the include path (and similiarly for the other MCU types), but this folder does not exist anymore.

VSCode emits a "Problem" warning for non-existing folders declared in the therefrom created .vscode/c_cpp_properties.json.

grafik

The fix trivially removes these folders from the include path. If the include/config folder was renamed and is not yet in the PlatformIO builder script, let me know.

Tests scenarios

Tested with PlatformIO using

[env:esp32dev]
platform = espressif32
board = esp32dev
framework = arduino
platform_packages = 
   framework-arduinoespressif32@https://github.com/maxgerhardt/arduino-esp32.git#patch-2

and the "Problems" view cleared out.

grafik

Related links

None.

@me-no-dev
Copy link
Member

This actually needs fixing in the lib-builder

me-no-dev added a commit to espressif/esp32-arduino-lib-builder that referenced this pull request May 27, 2022
@me-no-dev
Copy link
Member

OK. Thanks :) Merging here and already fixed in the lib-builder for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE: PlaformIO Issue relates to PlatformIO IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants