Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #include <vector> into BLEAdvertisedDevice.h #6990

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

PilnyTomas
Copy link
Contributor

Description of Change

Added #include <vector> into BLEAdvertisedDevice.h
On Windows when including BLEAdvertisedDevice.h there was an error 'vector' in namespace 'std' does not name a template type

Tests scenarios

Tested compilation of almost empty/default sketch, only added #include <BLEAdvertisedDevice.h> on Windows in Arduino IDE 1.8.19
Without the fix appear error mentioned here.
With the fix successfully compiles.

Related links

Partially related to #6593 (original problem is different)

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider
Copy link
Collaborator

Tested. Everything is fine. This is a simple change. No need for further reviewing. Ready for merging.

@SuGlider SuGlider merged commit 5f427c9 into espressif:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants