Skip to content

Conversation

mazgch
Copy link
Contributor

@mazgch mazgch commented Jul 18, 2022


Description of Change

compiler will complain with an error
esp32/2.0.4/libraries/WiFi/src/WiFiGeneric.cpp:499:48: error: unused variable 'event' [-Werror=unused-variable]
about unused variable event if compiled when ARDUHAL_LOG_LEVEL was set < ARDUHAL_LOG_LEVEL_VERBOSE.

Tests scenarios

When compiled in Arduino it throws an error, check it will no longer throw an error.

otherwise the compiler will complain about unused variable event
@SuGlider SuGlider requested a review from PilnyTomas July 19, 2022 02:48
@VojtechBartoska VojtechBartoska added the Area: BT&Wifi BT & Wifi related issues label Jul 20, 2022
Copy link
Contributor

@PilnyTomas PilnyTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for PR @mazgch 👍

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 26, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit e67bc02 into espressif:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants