Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./.github/scripts: Restore the build directory #7037

Merged
merged 4 commits into from
Jul 26, 2022
Merged

./.github/scripts: Restore the build directory #7037

merged 4 commits into from
Jul 26, 2022

Conversation

Ouss4
Copy link
Contributor

@Ouss4 Ouss4 commented Jul 25, 2022

Description of Change

The default build directory was changed during the last PR to accomodate the multi-configurations build. However, this also changed it for a single sketch build. This had a side effect of requiring to pass it as a parameter to pytest because pytest-emebdded default to build if none is provided. So the command became:pytest tests --build-dir build0 -k hello_world. This PR brings the old behavior for single sketch builds so one can test with just pytest tests -k hello_world.

Tests scenarios

Locally with the scripts and the test sketches present in-tree. The CI will test more.

Related links

N/A

@Ouss4
./.github/scripts: When only when skecth is built, the build directory
35c44f9 
should default to "build".

Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
@Ouss4 Ouss4 added the hil_test Run Hardware Tests label Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022 •
edited
Loading

Unit Test Results

15 files  15 suites   2m 10s ⏱️
  7 tests   7 ✔️ 0 💤 0 ❌
24 runs  24 ✔️ 0 💤 0 ❌

Results for commit b6291e4.

♻️ This comment has been updated with latest results.

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, tested locally and everything works.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 26, 2022
@SuGlider SuGlider merged commit 4b64cde into espressif:master Jul 26, 2022
@Ouss4 Ouss4 deleted the build_default branch July 26, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
hil_test Run Hardware Tests Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ouss4 @P-R-O-C-H-Y @SuGlider @VojtechBartoska