Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainmaker: Added enableSystemService API #7875

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

sanketwadekar
Copy link
Contributor

Description of Change

This PR creates a new API that will allow users to reboot and reset(Wi-Fi and Factory) from the Rainmaker app.
I have tested my Pull Request on Arduino-esp32 core v2.0.6 with ESP32C3 Board.

@sanketwadekar
Copy link
Contributor Author

cc @shahpiyushv

@me-no-dev
Copy link
Member

Hi @sanketwadekar doc CI is failing

@VojtechBartoska VojtechBartoska added the Area: Rainmaker Issue is related to ESP Rainmaker. label Feb 22, 2023
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor suggestion, otherwise, LGTM.

docs/source/api/rainmaker.rst Outdated Show resolved Hide resolved
@pedrominatel pedrominatel added the Status: Pending Merge Pull Request is ready to be merged label Feb 24, 2023
@pedrominatel pedrominatel added this to the 2.0.8 milestone Feb 24, 2023
@me-no-dev me-no-dev merged commit c6b850b into espressif:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Rainmaker Issue is related to ESP Rainmaker. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants