Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTTPUpdate request callback #7934

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Conversation

perotom
Copy link
Contributor

@perotom perotom commented Mar 6, 2023

Description of Change

This pull request gives users the possibility to modify the update request to their needs. In the given example we add http header basic authentication.

Tests scenarios

Tested on ESP32-C3.

Related links

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Mar 22, 2023
@PilnyTomas
Copy link
Contributor

Hi, I have run CI checks and there seems to be a compilation error:

/home/runner/work/arduino-esp32/arduino-esp32/libraries/HTTPUpdate/examples/httpUpdateSecure/httpUpdateSecure.ino:111:6:
error: invalid user-defined conversion from 'loop()::<lambda(HTTPClient*)>' to 'uint16_t' {aka 'short unsigned int'} [-fpermissive]

@perotom
Copy link
Contributor Author

perotom commented Mar 23, 2023

Sorry, I just fixed the example. It should compile now.

Copy link
Contributor

@PilnyTomas PilnyTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit bef8a75 into espressif:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review needed Issue or PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants