Skip to content

Documentation update in preferences.rst : fix return value of getBytes #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

Documentation update in preferences.rst : fix return value of getBytes #7981

merged 1 commit into from
Mar 31, 2023

Conversation

supcik
Copy link
Contributor

@supcik supcik commented Mar 21, 2023

Description of Change

The getBytes seems to return the number of bytes copied and not just 1.

Tests scenarios

n/a

Related links

Source file:

arduino-esp32/libraries/Preferences/src/Preferences.cpp

Line 509 in 0d84018

size_t Preferences::getBytes(const char* key, void * buf, size_t maxLen){

mrengineer7777
mrengineer7777 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@mrengineer7777 mrengineer7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechBartoska VojtechBartoska added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Mar 22, 2023
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Mar 22, 2023
PilnyTomas
PilnyTomas approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@PilnyTomas PilnyTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechBartoska VojtechBartoska added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 23, 2023
@VojtechBartoska
Copy link
Contributor

Thanks for reviews @mrengineer7777 & @PilnyTomas.

@me-no-dev me-no-dev merged commit 8ebf758 into espressif:master Mar 31, 2023
@supcik supcik deleted the patch-1 branch March 31, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

2 more reviewers

@PilnyTomas PilnyTomas PilnyTomas approved these changes

@mrengineer7777 mrengineer7777 mrengineer7777 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@supcik @VojtechBartoska @PilnyTomas @mrengineer7777 @me-no-dev