Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CameraWebserver.ino CI Warning #8149

Merged

Conversation

mrengineer7777
Copy link
Collaborator

Description of Change

Resolves deprecation warnings in CameraWebServer.ino.
pin_sscb_sda -> pin_sccb_sda. (note the change from ss to sc)
pin_sscb_scl -> pin_sccb_scl.

Issue

Building Sketch Index 16 - CameraWebServer ....
/CameraWebServer.ino:63:10: warning: 'camera_config_t::<unnamed union>::pin_sscb_sda' is deprecated: please use pin_sccb_sda instead ....
   config.pin_sscb_sda = SIOD_GPIO_NUM;
....
/CameraWebServer.ino:64:10: warning: 'camera_config_t::<unnamed union>::pin_sscb_scl' is deprecated: please use pin_sccb_scl instead ....
   config.pin_sscb_scl = SIOC_GPIO_NUM;

Tests scenarios

This is a simple variable rename. The variables are in the same union and are identical.

Related links

"esp32/tools/sdk/esp32s2/include/esp32-camera/driver/include/esp_camera.h"

Helps advance PR #7060

Resolves deprecation warnings in CameraWebServer.ino. pin_sscb_sda -> pin_sccb_sda. pin_sscb_scl -> pin_sccb_scl.
The variables are in the same union and are identical.
@mrengineer7777
Copy link
Collaborator Author

Confirmed Building Sketch Index 16 - CameraWebServer builds without warning for CI "Arduino 1 for Ubuntu latest".

@VojtechBartoska VojtechBartoska added the Type: Example Issue is related to specific example. label May 3, 2023
@VojtechBartoska VojtechBartoska added this to the 2.0.9 milestone May 3, 2023
@me-no-dev me-no-dev merged commit 8f4f21c into espressif:master May 3, 2023
42 checks passed
@mrengineer7777 mrengineer7777 deleted the Fix_CI_Warning_CameraWebServer branch May 3, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Example Issue is related to specific example.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants