Skip to content

secrets #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

secrets #8310

wants to merge 11 commits into from

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Jun 13, 2023 •
edited
Loading

Why?

  1. DRY (Don't Repeat Yourself) - having your passwords in one place is more manageable than changing them manually in each example, or new sketch.
  2. Secure - safely share the code without worrying about accidentally leaving WiFi credentials (I know!)

TODO: better implementation
TODO: testing

@PilnyTomas PilnyTomas added Status: To be implemented Selected for Development Status: In Progress ⚠️ Issue is in progress Type: Example Issue is related to specific example. Area: WiFi Issue related to WiFi labels Jun 13, 2023
@PilnyTomas PilnyTomas self-assigned this Jun 13, 2023
@PilnyTomas PilnyTomas marked this pull request as draft June 13, 2023 04:28
@PilnyTomas PilnyTomas requested a review from me-no-dev June 13, 2023 04:29
torntrousers
torntrousers reviewed Jun 13, 2023
View reviewed changes
@mrengineer7777
Copy link
Collaborator

Excellent idea

@VojtechBartoska
Copy link
Contributor

VojtechBartoska commented Jun 14, 2023 •
edited
Loading

  • this needs to be properly documented.
  • please target 5.1-libs branch

@PilnyTomas PilnyTomas changed the base branch from master to esp-idf-v5.1-libs June 14, 2023 13:09
@PilnyTomas
Copy link
Contributor Author

PilnyTomas commented Jun 14, 2023 •
edited
Loading

  • this needs to be properly documented.

docs/source/guides/secrets.rst

  • please target 5.1-libs branch

Done

brentru
brentru reviewed Jun 14, 2023
View reviewed changes
brentru
brentru reviewed Jun 14, 2023
View reviewed changes
@PilnyTomas PilnyTomas marked this pull request as ready for review June 26, 2023 12:56
@me-no-dev me-no-dev added this to the 3.0.0 milestone Jul 20, 2023
@PilnyTomas PilnyTomas changed the title Draft: secrets secrets Aug 7, 2023
@PilnyTomas
Copy link
Contributor Author

@me-no-dev please suggest a better implementation as you mentioned on calls.

@VojtechBartoska VojtechBartoska self-assigned this Aug 15, 2023
@me-no-dev
Copy link
Member

Closing this for now. Will revisit the feature later

@me-no-dev me-no-dev closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

@torntrousers torntrousers Awaiting requested review from torntrousers

1 more reviewer

@brentru brentru brentru left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@PilnyTomas PilnyTomas

@VojtechBartoska VojtechBartoska

Labels
Area: WiFi Issue related to WiFi Status: In Progress ⚠️ Issue is in progress Status: To be implemented Selected for Development Type: Example Issue is related to specific example.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PilnyTomas @mrengineer7777 @VojtechBartoska @me-no-dev @brentru @torntrousers